test: covering Batches API and partially covered Transactions #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covering Batches API
API E2E Test Results206 tests 206 ✅ 28s ⏱️ Results for commit c9537b9. ♻️ This comment has been updated with latest results. |
|
Visit the preview URL for this PR (updated for commit c9537b9):
(expires Tue, 06 Feb 2024 13:56:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
Unit Test Results 3 files 247 suites 8m 35s ⏱️ Results for commit c9537b9. ♻️ This comment has been updated with latest results. |
|
@pcheremu could you please review the PR? |
|
@amelnytskyi please also fix failed ui test: ✘ 5 [chromium] › nft.spec.ts:32:5 › Check the L1 NFT contract address |
# What ❔
Added test for TC id1803 /tokens/{address}/transfers endpoint
## Why ❔
Expand test coverage - id1803 wasn't covered by autotest
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
Fixed TC id1657 - Check the L1 NFT contract address
covering Batches API
Fixed TC id1657 - Check the L1 NFT contract address
…://github.com/matter-labs/block-explorer into QA-538-cover-batches-endpoint-and-failed-tx-fix
@pcheremu fix for "Check the L1 NFT contract address" added - you can review again |
pcheremu
approved these changes
Jan 30, 2024
pcheremu
pushed a commit
that referenced
this pull request
Feb 9, 2024
covering Batches API
# What ❔
1506 [Transactions] /transactions response returns elements (wasn't
covered fully)
1513 [Batches] /batches response returns elements (wasn't covered fully)
1510 [Transactions] /address/{address}/logs response returns elements
(wasn't covered fully)
1656 [Transactions] Verify failed tx (new test)
1655 [Transactions] Verify deployed the own ERC20 token contract in BE
(new test)
## Why ❔
Why are these changes done? - expanding test coverage
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ n/a] Documentation comments have been added / updated.
pcheremu
pushed a commit
that referenced
this pull request
Feb 9, 2024
covering Batches API
# What ❔
1506 [Transactions] /transactions response returns elements (wasn't
covered fully)
1513 [Batches] /batches response returns elements (wasn't covered fully)
1510 [Transactions] /address/{address}/logs response returns elements
(wasn't covered fully)
1656 [Transactions] Verify failed tx (new test)
1655 [Transactions] Verify deployed the own ERC20 token contract in BE
(new test)
## Why ❔
Why are these changes done? - expanding test coverage
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ n/a] Documentation comments have been added / updated.
pcheremu
pushed a commit
that referenced
this pull request
Feb 15, 2024
covering Batches API
# What ❔
1506 [Transactions] /transactions response returns elements (wasn't
covered fully)
1513 [Batches] /batches response returns elements (wasn't covered fully)
1510 [Transactions] /address/{address}/logs response returns elements
(wasn't covered fully)
1656 [Transactions] Verify failed tx (new test)
1655 [Transactions] Verify deployed the own ERC20 token contract in BE
(new test)
## Why ❔
Why are these changes done? - expanding test coverage
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ n/a] Documentation comments have been added / updated.
pcheremu
pushed a commit
that referenced
this pull request
Jul 5, 2024
covering Batches API
# What ❔
1506 [Transactions] /transactions response returns elements (wasn't
covered fully)
1513 [Batches] /batches response returns elements (wasn't covered fully)
1510 [Transactions] /address/{address}/logs response returns elements
(wasn't covered fully)
1656 [Transactions] Verify failed tx (new test)
1655 [Transactions] Verify deployed the own ERC20 token contract in BE
(new test)
## Why ❔
Why are these changes done? - expanding test coverage
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ n/a] Documentation comments have been added / updated.
pcheremu
pushed a commit
that referenced
this pull request
Aug 22, 2024
covering Batches API
# What ❔
1506 [Transactions] /transactions response returns elements (wasn't
covered fully)
1513 [Batches] /batches response returns elements (wasn't covered fully)
1510 [Transactions] /address/{address}/logs response returns elements
(wasn't covered fully)
1656 [Transactions] Verify failed tx (new test)
1655 [Transactions] Verify deployed the own ERC20 token contract in BE
(new test)
## Why ❔
Why are these changes done? - expanding test coverage
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ n/a] Documentation comments have been added / updated.
pcheremu
pushed a commit
that referenced
this pull request
Aug 22, 2024
covering Batches API
# What ❔
1506 [Transactions] /transactions response returns elements (wasn't
covered fully)
1513 [Batches] /batches response returns elements (wasn't covered fully)
1510 [Transactions] /address/{address}/logs response returns elements
(wasn't covered fully)
1656 [Transactions] Verify failed tx (new test)
1655 [Transactions] Verify deployed the own ERC20 token contract in BE
(new test)
## Why ❔
Why are these changes done? - expanding test coverage
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ n/a] Documentation comments have been added / updated.
pcheremu
pushed a commit
that referenced
this pull request
Aug 23, 2024
covering Batches API
# What ❔
1506 [Transactions] /transactions response returns elements (wasn't
covered fully)
1513 [Batches] /batches response returns elements (wasn't covered fully)
1510 [Transactions] /address/{address}/logs response returns elements
(wasn't covered fully)
1656 [Transactions] Verify failed tx (new test)
1655 [Transactions] Verify deployed the own ERC20 token contract in BE
(new test)
## Why ❔
Why are these changes done? - expanding test coverage
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ n/a] Documentation comments have been added / updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
covering Batches API
What ❔
1506 [Transactions] /transactions response returns elements (wasn't covered fully)
1513 [Batches] /batches response returns elements (wasn't covered fully)
1510 [Transactions] /address/{address}/logs response returns elements (wasn't covered fully)
1656 [Transactions] Verify failed tx (new test)
1655 [Transactions] Verify deployed the own ERC20 token contract in BE (new test)
Why ❔
Why are these changes done? - expanding test coverage
Checklist