-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove portal from header #159
Merged
vasyl-ivanchuk
merged 8 commits into
main
from
devrl-340-be-remove-portal-item-from-tools-header
Feb 6, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
775228e
fix: remove portal from header
vasyl-ivanchuk 0a35dcb
test: comment e2e tests for Portal links
vasyl-ivanchuk 576dcc3
fix: run prod mode in docker compose
vasyl-ivanchuk f31ea0a
fix: increase the number of zksync container health retries
vasyl-ivanchuk 66c0178
fix: update tests for removing duplicate portal links (#160)
olehbairak 9532882
feat: add zkVM checkbox filter to verification page
vasyl-ivanchuk 3688a42
fix: checkbox input type
vasyl-ivanchuk 82b5353
fix: remove value variable from the CheckBoxInput component
vasyl-ivanchuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| **/dist/ | ||
| **/dist/ | ||
| **.env |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
packages/app/src/components/common/CheckBoxInput.stories.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import CheckBoxInput from "./CheckBoxInput.vue"; | ||
|
|
||
| export default { | ||
| title: "Common/CheckBoxInput", | ||
| component: CheckBoxInput, | ||
| }; | ||
|
|
||
| type Args = { | ||
| modelValue: boolean; | ||
| }; | ||
|
|
||
| const Template = (args: Args) => ({ | ||
| components: { CheckBoxInput }, | ||
| setup() { | ||
| return { args }; | ||
| }, | ||
| template: ` | ||
| <CheckBoxInput v-bind="args">CheckBox Input</CheckBoxInput>`, | ||
| }); | ||
|
|
||
| export const Checked = Template.bind({}) as unknown as { args: Args }; | ||
| Checked.args = { | ||
| modelValue: true, | ||
| }; | ||
|
|
||
| export const Unchecked = Template.bind({}) as unknown as { args: Args }; | ||
| Unchecked.args = { | ||
| modelValue: false, | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| <template> | ||
| <label class="checkbox-input-container" :class="{ checked: inputted }"> | ||
| <input type="checkbox" :checked="inputted" v-model="inputted" v-bind="$attrs" /> | ||
| <slot /> | ||
| </label> | ||
| </template> | ||
|
|
||
| <script lang="ts"> | ||
| export default { | ||
| inheritAttrs: false, | ||
| }; | ||
| </script> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { computed } from "vue"; | ||
| const props = defineProps({ | ||
| modelValue: { | ||
| type: Boolean, | ||
| default: null, | ||
| }, | ||
| }); | ||
| const emit = defineEmits<{ | ||
| (eventName: "update:modelValue", value: unknown): void; | ||
| }>(); | ||
|
|
||
| const inputted = computed({ | ||
| get: () => props.modelValue, | ||
| set: (value: unknown) => { | ||
| emit("update:modelValue", value); | ||
| }, | ||
| }); | ||
| </script> | ||
|
|
||
| <style lang="scss" scoped> | ||
| .checkbox-input-container { | ||
| @apply flex items-center mb-1 cursor-pointer float-right leading-snug; | ||
|
|
||
| input { | ||
| @apply rounded me-1 text-primary-600 cursor-pointer border-neutral-200 checked:border-primary-600 hover:border-primary-600 ring-transparent; | ||
| } | ||
| } | ||
| </style> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,7 @@ defineProps({ | |
| } | ||
| .label-inline-block { | ||
| .form-item-label { | ||
| @apply inline-block; | ||
| @apply float-left; | ||
| } | ||
| } | ||
| </style> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure it won't break any existing use cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. This class used in two places and I checked them both.