Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update tests for removing duplicate portal links #160

Conversation

olehbairak
Copy link
Contributor

@olehbairak olehbairak commented Jan 31, 2024

What ❔

In the scope of this PR several changes to automation tests were performed. Based on the PR. Where Portal links were removed and replaced with one solid approach - to display link to Bridge as unified platform that we currently use.

Why ❔

To have automation tests coverage up-to-date with recent changes and not to block ci/cd run with incorrect behaviour for old link.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@olehbairak olehbairak added the automation writing/fixing/maintaining auto-tests/e2e-tests label Jan 31, 2024
@olehbairak olehbairak self-assigned this Jan 31, 2024
Copy link

github-actions bot commented Jan 31, 2024

API E2E Test Results

206 tests  ±0   206 ✅ ±0   29s ⏱️ -1s
 14 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 19b8a4f. ± Comparison against base commit f31ea0a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 31, 2024

Visit the preview URL for this PR (updated for commit 19b8a4f):

(expires Thu, 08 Feb 2024 17:09:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

Copy link

github-actions bot commented Jan 31, 2024

Unit Test Results

    4 files  ±0    262 suites  ±0   13m 25s ⏱️ +3s
2 071 tests ±0  2 070 ✅ ±0  1 💤 ±0  0 ❌ ±0 
2 276 runs  ±0  2 275 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 19b8a4f. ± Comparison against base commit f31ea0a.

♻️ This comment has been updated with latest results.

@olehbairak olehbairak changed the title Update tests for removing duplicate portal links fix: update tests for removing duplicate portal links Jan 31, 2024
@olehbairak olehbairak marked this pull request as ready for review January 31, 2024 16:53
@olehbairak olehbairak requested a review from pcheremu January 31, 2024 16:53
Copy link
Contributor

@pcheremu pcheremu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give me more input, to proceed.

@olehbairak olehbairak requested a review from pcheremu February 1, 2024 10:44
@olehbairak olehbairak requested a review from pcheremu February 2, 2024 09:32
@pcheremu pcheremu merged commit 66c0178 into devrl-340-be-remove-portal-item-from-tools-header Feb 2, 2024
25 checks passed
@pcheremu pcheremu deleted the update-tests-for-removing-duplicate-portal-links-and branch February 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation writing/fixing/maintaining auto-tests/e2e-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants