-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update tests for removing duplicate portal links #160
Merged
pcheremu
merged 13 commits into
devrl-340-be-remove-portal-item-from-tools-header
from
update-tests-for-removing-duplicate-portal-links-and
Feb 2, 2024
Merged
fix: update tests for removing duplicate portal links #160
pcheremu
merged 13 commits into
devrl-340-be-remove-portal-item-from-tools-header
from
update-tests-for-removing-duplicate-portal-links-and
Feb 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 19b8a4f):
(expires Thu, 08 Feb 2024 17:09:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
olehbairak
changed the title
Update tests for removing duplicate portal links
fix: update tests for removing duplicate portal links
Jan 31, 2024
pcheremu
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please give me more input, to proceed.
packages/app/tests/e2e/features/artifacts/artifactsSet1.feature
Outdated
Show resolved
Hide resolved
packages/app/tests/e2e/features/artifacts/artifactsSet1.feature
Outdated
Show resolved
Hide resolved
packages/app/tests/e2e/features/artifacts/artifactsSet1.feature
Outdated
Show resolved
Hide resolved
packages/app/tests/e2e/features/redirection/redirectionSet1.feature
Outdated
Show resolved
Hide resolved
pcheremu
reviewed
Feb 1, 2024
packages/app/tests/e2e/features/artifacts/artifactsSet1.feature
Outdated
Show resolved
Hide resolved
pcheremu
approved these changes
Feb 2, 2024
pcheremu
merged commit Feb 2, 2024
66c0178
into
devrl-340-be-remove-portal-item-from-tools-header
25 checks passed
pcheremu
deleted the
update-tests-for-removing-duplicate-portal-links-and
branch
February 2, 2024 11:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
In the scope of this PR several changes to automation tests were performed. Based on the PR. Where Portal links were removed and replaced with one solid approach - to display link to Bridge as unified platform that we currently use.
Why ❔
To have automation tests coverage up-to-date with recent changes and not to block ci/cd run with incorrect behaviour for old link.
Checklist