test: fixing gating transactions tests #162
Conversation
Fixed disabled /transactions/{transactionHash}/transfers tests and turned them on back
API E2E Test Results206 tests 206 ✅ 28s ⏱️ Results for commit 1a32c11. ♻️ This comment has been updated with latest results. |
|
Visit the preview URL for this PR (updated for commit 1a32c11):
(expires Tue, 13 Feb 2024 14:05:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
Unit Test Results 3 files 247 suites 8m 38s ⏱️ Results for commit 1a32c11. ♻️ This comment has been updated with latest results. |
Fixed failing test id1506 "Verify the transaction via /transactions"
Fixing spaces
Fixing spaces
| @@ -381,7 +462,20 @@ describe("Transactions", () => { | |||
| ); | |||
There was a problem hiding this comment.
Probably some fields missed?
"items": [
{
"from": "0x3c0FD3279c2b714141aa731519b68Bd428454073",
"to": "0x0000000000000000000000000000000000008001",
"blockNumber": 16511607,
"transactionHash": "0xbe1334c29408d1fe90a810fbda46da059f18cef033bfb08d75050c531b5c789e",
"timestamp": "2024-02-06T10:44:38.831Z",
"amount": "1503311400000000",
"tokenAddress": "0x000000000000000000000000000000000000800A",
"type": "fee",
"tokenType": "ETH",
"fields": null,
"isInternal": false,
"token": {
"l2Address": "0x000000000000000000000000000000000000800A",
"l1Address": "0x0000000000000000000000000000000000000000",
"symbol": "ETH",
"name": "Ether",
"decimals": 18,
"usdPrice": 2294.85,
"liquidity": 275206159445,
"iconURL": "https://assets.coingecko.com/coins/images/279/large/ethereum.png?1696501628"
}
},
There was a problem hiding this comment.
please create a task to refactor tx tests in the next PR
| usdPrice: 1800, | ||
| }, | ||
| }) | ||
| ); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
on 534, do we need a token and blocknumber data?
There was a problem hiding this comment.
please create a task to refactor tx tests in the next PR
There was a problem hiding this comment.
Fixes itself looks good, I just see that some tests outdated or some fields are missed. It will be good to keep them up-to date together with its fixes. AFAK it is not necessary to be so detailed for items [1] or [2] but we have a full list of items for the item [0] if any.
# What ❔
Fixed disabled (xdescribe and xit)
/transactions/{transactionHash}/transfers tests and turned them on back
## Why ❔
/transactions/{transactionHash}/transfers tests were disabled since they
were outdated
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ -] Documentation comments have been added / updated.
# What ❔
Fixed disabled (xdescribe and xit)
/transactions/{transactionHash}/transfers tests and turned them on back
## Why ❔
/transactions/{transactionHash}/transfers tests were disabled since they
were outdated
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ -] Documentation comments have been added / updated.
# What ❔
Fixed disabled (xdescribe and xit)
/transactions/{transactionHash}/transfers tests and turned them on back
## Why ❔
/transactions/{transactionHash}/transfers tests were disabled since they
were outdated
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ -] Documentation comments have been added / updated.
# What ❔
Fixed disabled (xdescribe and xit)
/transactions/{transactionHash}/transfers tests and turned them on back
## Why ❔
/transactions/{transactionHash}/transfers tests were disabled since they
were outdated
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ -] Documentation comments have been added / updated.
# What ❔
Fixed disabled (xdescribe and xit)
/transactions/{transactionHash}/transfers tests and turned them on back
## Why ❔
/transactions/{transactionHash}/transfers tests were disabled since they
were outdated
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ -] Documentation comments have been added / updated.
# What ❔
Fixed disabled (xdescribe and xit)
/transactions/{transactionHash}/transfers tests and turned them on back
## Why ❔
/transactions/{transactionHash}/transfers tests were disabled since they
were outdated
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ -] Documentation comments have been added / updated.
# What ❔
Fixed disabled (xdescribe and xit)
/transactions/{transactionHash}/transfers tests and turned them on back
## Why ❔
/transactions/{transactionHash}/transfers tests were disabled since they
were outdated
## Checklist
- [ +] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ +] Tests for the changes have been added / updated.
- [ -] Documentation comments have been added / updated.
What ❔
Fixed disabled (xdescribe and xit) /transactions/{transactionHash}/transfers tests and turned them on back
Why ❔
/transactions/{transactionHash}/transfers tests were disabled since they were outdated
Checklist