test: covering UI tests for Deposit #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 4babcac):
(expires Mon, 11 Mar 2024 17:13:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
pcheremu
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Looks good,
@abilevych this part Artem changed using Vasyl's recommendations. fyi
abilevych
suggested changes
Mar 4, 2024
packages/integration-tests/src/playbook/scenarios/deposit/depositERC20.ts
Outdated
Show resolved
Hide resolved
packages/integration-tests/src/playbook/scenarios/deposit/depositERC20.ts
Outdated
Show resolved
Hide resolved
Changed timeout value in Deposit UI tests Renamed variables to suggested values as per review results Removed obsolete console.log
|
@abilevych requested changes added - could you please review again? |
abilevych
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist