test: automation tests for Transactions + Withdrawal API #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 5be1de1):
(expires Fri, 08 Mar 2024 11:03:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
pcheremu
reviewed
Feb 29, 2024
| @@ -49,6 +49,8 @@ export enum Token { | |||
| ETHER_PULL_Address = "0x0000000000000000000000000000000000008001", | |||
| ETHER_Address = "0x0000000000000000000000000000000000000000", | |||
| ETHER_ERC20_Address = "0x000000000000000000000000000000000000800A", | |||
| tokenTypeERC20 = "ERC20", | |||
| tokenTypeETH = "ETH", | |||
There was a problem hiding this comment.
that is good that you have decided to move it separately, but then you have to align all tests:
I would also suggest to simplify the name:
ERC20_Name = "ERC20",
ETH_Name = "ETH",
pcheremu
reviewed
Feb 29, 2024
| @@ -86,25 +97,33 @@ describe("Transactions", () => { | |||
| apiRoute = `/transactions/${txHash}/transfers`; | |||
| response = await helper.performGETrequest(apiRoute); | |||
|
|
|||
| console.log(response.body); | |||
pcheremu
suggested changes
Feb 29, 2024
…actions-create-automation-tests
|
@pcheremu closing this PR due to the fact, that these fixes were already present in integration-test-signed branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Increase automation coverage with next test cases:
Transactions: -> DONE ✅
https://allure.matterlabs.dev/project/11/test-cases/1509 ✅
https://allure.matterlabs.dev/project/11/test-cases/1452 ✅
Withdrawal API: -DONE ✅
https://allure.matterlabs.dev/project/11/test-cases/1459 ✅
https://allure.matterlabs.dev/project/11/test-cases/1460 ✅
https://allure.matterlabs.dev/project/11/test-cases/1461 ✅
Why ❔
Extend automation test coverage with new areas of coverage.
Checklist