-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: create autotests for Withdraw test cases #190
test: create autotests for Withdraw test cases #190
Conversation
Visit the preview URL for this PR (updated for commit 745ce83):
(expires Wed, 20 Mar 2024 12:14:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably the PR can be optimized by comments above.
Removing obsolete variables
17ea962
to
a6bf6af
Compare
Fixed Lint issues/warnings
@abilevych conflicts resolved after rebase and fixes - ready for review again |
Fixed explicit timeout and changed const txSumETH to enum data type
@abilevych all requested changes added - could you please review? |
What ❔
1686 [Withdrawal] Check on BE Verify the ETH withdrawal to the other address via /transactions/{transactionHash}/transfers
1685 [Transactions] Check on BE Withdraw the custom ERC-20 via Portal (zkSync SDK)
1664 [Transactions] Check Withdraw transaction on BE for custom ERC-20 token (USDC) to a different address token via Portal (zkSync SDK)
1661 [Transactions] Check Withdraw ETH transaction on BE (zkSync SDK)
Why ❔
Checklist