Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial changes to show base token - SQUASHED #260

Conversation

SantiagoPittella
Copy link
Contributor

What ❔

REPLACES PR #172 .
#172 can be closed after this one.

Why ❔

This new PR exists to create a single squashed commit with all the changes.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@SantiagoPittella
Copy link
Contributor Author

@vasyl-ivanchuk feel free to review this instead of #172 .

};
const defaultEthBaseToken: BaseToken = {
l2Address: BASE_TOKEN_L2_ADDRESS,
l1Address: "0x0000000000000000000000000000000000000001",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 0x...0001?

import { utils } from "zksync-ethers";
console.log(utils.ETH_ADDRESS) //-> 0x...000

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was outdated with some kl-factory changes. Changed now.

@@ -15,3 +15,10 @@ DISABLE_EXTERNAL_API=false
DATABASE_STATEMENT_TIMEOUT_MS=90000
CONTRACT_VERIFICATION_API_URL=http://127.0.0.1:3070
NETWORK_NAME=testnet-sepolia
BASE_TOKEN_SYMBOL=wETH
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set it to ETH here so that if I copy the example env ETH is set by default.

@SantiagoPittella
Copy link
Contributor Author

@Romsters please review.

@ilitteri ilitteri requested a review from vasyl-ivanchuk July 30, 2024 15:59
@vasyl-ivanchuk
Copy link
Collaborator

Closing this PR as these changes have been already merged in this #273.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants