-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial changes to show base token - SQUASHED #260
feat: initial changes to show base token - SQUASHED #260
Conversation
@vasyl-ivanchuk feel free to review this instead of #172 . |
packages/api/src/config/index.ts
Outdated
}; | ||
const defaultEthBaseToken: BaseToken = { | ||
l2Address: BASE_TOKEN_L2_ADDRESS, | ||
l1Address: "0x0000000000000000000000000000000000000001", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 0x...0001?
import { utils } from "zksync-ethers";
console.log(utils.ETH_ADDRESS) //-> 0x...000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was outdated with some kl-factory
changes. Changed now.
packages/api/.env.example
Outdated
@@ -15,3 +15,10 @@ DISABLE_EXTERNAL_API=false | |||
DATABASE_STATEMENT_TIMEOUT_MS=90000 | |||
CONTRACT_VERIFICATION_API_URL=http://127.0.0.1:3070 | |||
NETWORK_NAME=testnet-sepolia | |||
BASE_TOKEN_SYMBOL=wETH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set it to ETH here so that if I copy the example env ETH is set by default.
@Romsters please review. |
…w-native-erc20-token-info-squashd
Closing this PR as these changes have been already merged in this #273. |
What ❔
REPLACES PR #172 .
#172 can be closed after this one.
Why ❔
This new PR exists to create a single squashed commit with all the changes.
Checklist