Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hyperchain base address #276

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

vasyl-ivanchuk
Copy link
Collaborator

What ❔

Adding missing baseTokenAddress to the hyperchain configuration.
Adding a fallback to use the default L2 base token address if it's not specified in the config.

Why ❔

When configuring the block explorer using npm run hyperchain:configure, the resulting configuration was missing the baseTokenAddress value. This absence was causing an error here. As a result of this error, the system was defaulting to Sepolia (which I assume is not the intended behavior for your hyperchain setup).

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@vasyl-ivanchuk vasyl-ivanchuk changed the title Fix hyperchain base address fix: hyperchain base address Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

API E2E Test Results

207 tests   207 ✅  20s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit d5e95d8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 22, 2024

Unit Test Results

    4 files    263 suites   11m 34s ⏱️
2 090 tests 2 089 ✅ 1 💤 0 ❌
2 299 runs  2 298 ✅ 1 💤 0 ❌

Results for commit d5e95d8.

♻️ This comment has been updated with latest results.

Copy link

Visit the preview URL for this PR:
https://staging-scan-v2--pr-276-073ko1y6.web.app

@vasyl-ivanchuk vasyl-ivanchuk force-pushed the fix-hyperchain-base-address branch from 0a8af9a to d5e95d8 Compare August 22, 2024 10:34
@vasyl-ivanchuk vasyl-ivanchuk merged commit f58cb8f into main Aug 22, 2024
24 checks passed
@vasyl-ivanchuk vasyl-ivanchuk deleted the fix-hyperchain-base-address branch August 22, 2024 10:50
Copy link

🎉 This PR is included in version 2.49.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants