Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default hyperchain base address #284

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

vasyl-ivanchuk
Copy link
Collaborator

What ❔

Fixing default base token address value in hyperchain setup script.

Why ❔

Base token address on L2 is always "800A". This script might not work for hyperchains with custom L1 base token.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Copy link

API E2E Test Results

207 tests   207 ✅  19s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit 143b09f.

Copy link

Unit Test Results

    4 files    263 suites   11m 40s ⏱️
2 090 tests 2 089 ✅ 1 💤 0 ❌
2 299 runs  2 298 ✅ 1 💤 0 ❌

Results for commit 143b09f.

Copy link

Visit the preview URL for this PR:
https://staging-scan-v2--pr-284-y2oidred.web.app

@vasyl-ivanchuk vasyl-ivanchuk merged commit d951ad0 into main Aug 27, 2024
35 of 36 checks passed
@vasyl-ivanchuk vasyl-ivanchuk deleted the fix-hyperchain-default-base-address branch August 27, 2024 08:03
Copy link

🎉 This PR is included in version 2.49.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants