feat: add support for evm-like contracts and transactions #337

tx-nikola · 2024-11-29T09:24:42Z

What ❔

Add badge that shows "EVM" for evm-like contracts and transactions.

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.

github-actions · 2024-11-29T09:26:11Z

API E2E Test Results

207 tests 207 ✅ 19s ⏱️
14 suites 0 💤
1 files 0 ❌

Results for commit e0fe9ea.

♻️ This comment has been updated with latest results.

github-actions · 2024-11-29T09:30:19Z

Unit Test Results

4 files 263 suites 11m 46s ⏱️
2 126 tests 2 125 ✅ 1 💤 0 ❌
2 338 runs 2 337 ✅ 1 💤 0 ❌

Results for commit e0fe9ea.

♻️ This comment has been updated with latest results.

github-actions · 2024-11-29T09:31:14Z

Visit the preview URL for this PR:
https://staging-scan-v2--pr-337-i06qnt0i.web.app

Romsters

Please use contractAddress field to store deployed contract address similar to etherscan, set to to zero address.

petarTxFusion · 2024-12-10T10:24:41Z

Please use contractAddress field to store deployed contract address similar to etherscan, set to to zero address.

Its implemented

Romsters · 2024-12-10T14:48:45Z

packages/api/src/common/transformers/normalizeAddress.transformer.ts

@@ -10,6 +10,9 @@ export const normalizeAddressTransformer: ValueTransformer = {
    if (!hex) {
      return null;
    }
+    if (hexTransformer.from(hex) === "0x") {


Why? Empty string doesn't look like a valid address. I'd prefer 0x0000...

0x00 and 0x are different values. Tx with empty to field is EVM deploy tx

But this function is supposed to normalise address, so it should always return an address, I mean it should be zero address instead of empty string.

Then we should process 0x differently, earlier, imo

If you keep getAddress(hexTransformer.from(hex)) wouldn't it just return a zero address?

No, it returns an error. I have left it like this in order to be aligned with etherscan since they are returning empty string in cases like this. We can switch to 0x000....

I don't have much context on the PR, but from what I've understood 0x is like of special case for contract deployment (like, and "empty to field"), which is different from 0x00..00 (IIRC in early times it was used for contract deployment, but nowadays you just don't specify anything).

Romsters · 2024-12-10T14:49:45Z

packages/api/src/transaction/dtos/transaction.dto.ts

@@ -14,7 +14,7 @@ export class TransactionDto {
    description: "The address this transaction is to",
    example: "0xc7e0220d02d549c4846A6EC31D89C3B670Ebe35C",
  })
-  public readonly to: string;
+  public readonly to?: string;


Why is it optional?

Initially we where supporting to as a null when we started with evm support. I will change that back as well as all other to fields

Romsters · 2024-12-10T14:51:02Z

packages/api/src/transaction/entities/addressTransaction.entity.ts

@@ -19,8 +19,8 @@ export class AddressTransaction extends BaseEntity {
  @Column({ type: "bytea", transformer: hexTransformer })
  public readonly transactionHash: string;

-  @Column({ type: "bytea", transformer: normalizeAddressTransformer })
-  public readonly address: string;
+  @Column({ type: "bytea", transformer: normalizeAddressTransformer, nullable: true })


why is it nullable?

Romsters · 2024-12-10T14:52:51Z

packages/api/src/transaction/entities/addressTransaction.entity.ts

@@ -31,4 +31,7 @@ export class AddressTransaction extends BaseEntity {

  @Column({ type: "int" })
  public readonly transactionIndex: number;
+
+  @Column({ type: "boolean", nullable: true })
+  public readonly isEvmLike?: boolean;


Does it have to be in this table?

Romsters · 2024-12-10T14:53:06Z

packages/api/src/transaction/entities/transaction.entity.ts

-  @Column({ type: "bytea", transformer: normalizeAddressTransformer })
-  public readonly to: string;
+  @Column({ type: "bytea", transformer: normalizeAddressTransformer, nullable: true })
+  public readonly to?: string;


why optional?

Romsters · 2024-12-10T14:57:20Z

packages/data-fetcher/src/transaction/transaction.service.ts

+    const toAddress = isEvmLike ? "0x" : transactionInfo.to;
+    const contractAddress = isEvmLike
+      ? getCreateAddress({ from: transactionInfo.from, nonce: transactionInfo.nonce })
+      : "";


Why empty string and not null?

To align with etherscan where they are leaving empty string in cases like that one.

vasyl-ivanchuk · 2024-12-10T17:49:35Z

packages/worker/src/entities/addressTransaction.entity.ts

@@ -35,4 +35,7 @@ export class AddressTransaction extends BaseEntity {

  @Column({ type: "int" })
  public readonly transactionIndex: number;
+
+  @Column({ type: "boolean", nullable: true })
+  public readonly isEvmLike?: boolean;


I don't think this field should be here, as this entity is used to query address transactions based on an address and join the corresponding transaction entities, which have all the fields available:

block-explorer/packages/api/src/transaction/transaction.service.ts

Line 62 in 0b1a667

queryBuilder.leftJoinAndSelect("addressTransaction.transaction", "transaction");

feat: add evm badge for evm-like contracts and transactions

aa261ba

tx-nikola added the frontend Task requires changes to the frontend implementation label Nov 29, 2024

tx-nikola self-assigned this Nov 29, 2024

feat: add support for EVM contracts and transactions

3350372

petarTxFusion changed the title ~~feat: add evm badge for evm-like contracts and transactions~~ feat: add support for evm-like contracts and transactions Nov 29, 2024

tx-nikola and others added 5 commits December 3, 2024 11:20

fix: change the wording and move badge to the 'To' field

f27a109

Merge branch 'main' into tx-nikola-txfusion-add-env-badge

68c8f5e

feat: for EVM deployment use contract address as to

6691dfe

feat: call endpoint to get contract address isEvmLike

cd3911b

test: fix tests

aadcc6d

petarTxFusion added the backend Task requires changes to the backend implementation label Dec 5, 2024

petarTxFusion and others added 4 commits December 5, 2024 14:40

test: fix tests

1ada4c4

test: fix tests

c32d786

feat: add 'Created' text in the 'To' field

5c61238

fix: add env badge to title of transaction

8de30cf

Romsters requested changes Dec 6, 2024

View reviewed changes

petarTxFusion added 3 commits December 10, 2024 02:44

feat: add ContractAddress to transaction info

d88f9fb

test: fix tests

b55ed5a

test: fix tests

2505085

petarTxFusion and others added 3 commits December 10, 2024 11:35

test: increase test coverage

8ea4838

fix(data-fetcher): calculate contract address for EVM transactions

75dbdbe

Merge branch 'main' into tx-nikola-txfusion-add-env-badge

84aadd6

Romsters reviewed Dec 10, 2024

View reviewed changes

vasyl-ivanchuk reviewed Dec 10, 2024

View reviewed changes

petarTxFusion and others added 3 commits December 10, 2024 21:40

fix: fix to and contractAddress null

d3d191b

test: fix tests

e0c1a2d

Merge branch 'main' into tx-nikola-txfusion-add-env-badge

e0fe9ea

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for evm-like contracts and transactions #337

feat: add support for evm-like contracts and transactions #337

tx-nikola commented Nov 29, 2024

github-actions bot commented Nov 29, 2024 •

edited

Loading

github-actions bot commented Nov 29, 2024 •

edited

Loading

github-actions bot commented Nov 29, 2024

Romsters left a comment

petarTxFusion commented Dec 10, 2024

Romsters Dec 10, 2024 •

edited

Loading

0xVolosnikov Dec 10, 2024

Romsters Dec 10, 2024

0xVolosnikov Dec 10, 2024 •

edited

Loading

Romsters Dec 10, 2024

petarTxFusion Dec 10, 2024

popzxc Dec 12, 2024

Romsters Dec 10, 2024

petarTxFusion Dec 10, 2024 •

edited

Loading

Romsters Dec 10, 2024

Romsters Dec 10, 2024

Romsters Dec 10, 2024

Romsters Dec 10, 2024

petarTxFusion Dec 10, 2024

vasyl-ivanchuk Dec 10, 2024 •

edited

Loading

feat: add support for evm-like contracts and transactions #337

Are you sure you want to change the base?

feat: add support for evm-like contracts and transactions #337

Conversation

tx-nikola commented Nov 29, 2024

What ❔

Checklist

github-actions bot commented Nov 29, 2024 • edited Loading

API E2E Test Results

github-actions bot commented Nov 29, 2024 • edited Loading

Unit Test Results

github-actions bot commented Nov 29, 2024

Romsters left a comment

Choose a reason for hiding this comment

petarTxFusion commented Dec 10, 2024

Romsters Dec 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xVolosnikov Dec 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petarTxFusion Dec 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vasyl-ivanchuk Dec 10, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Nov 29, 2024 •

edited

Loading

github-actions bot commented Nov 29, 2024 •

edited

Loading

Romsters Dec 10, 2024 •

edited

Loading

0xVolosnikov Dec 10, 2024 •

edited

Loading

petarTxFusion Dec 10, 2024 •

edited

Loading

vasyl-ivanchuk Dec 10, 2024 •

edited

Loading