Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nft support #384

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

kiriyaga-txfusion
Copy link
Contributor

What ❔

The PR includes NFT support, ensuring that every ERC-721 transfer is handled and saved as NftItems, with tokens tagged by type. Transfers in the API are extended with an nftItem object containing all necessary information for displaying NFTs in the transfers list and transaction details page.

Why ❔

Currently NFT transfers are shown without amount, name and image. Owned NFTs are not displayed in owned token balances list.

fixes: #364

Checklist

  • [+ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • [+] Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Copy link

github-actions bot commented Feb 12, 2025

API E2E Test Results

208 tests   208 ✅  20s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit 72ef98e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2025

Unit Test Results

    4 files    267 suites   11m 52s ⏱️
2 173 tests 2 168 ✅ 1 💤 4 ❌
2 387 runs  2 382 ✅ 1 💤 4 ❌

For more details on these failures, see this check.

Results for commit 72ef98e.

♻️ This comment has been updated with latest results.

Copy link

Visit the preview URL for this PR:
https://staging-scan-v2--pr-384-f27ool2u.web.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper NFT support
1 participant