chore: docker compose for cli #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Romsters
reviewed
Oct 13, 2023
docker-compose-cli.yaml
Outdated
| build: | ||
| context: . | ||
| dockerfile: ./packages/app/Dockerfile | ||
| command: npm run --prefix packages/app dev -- --host |
There was a problem hiding this comment.
why dev? For cli I'd suggest build + start
|
Visit the preview URL for this PR (updated for commit 6b61d51):
(expires Mon, 23 Oct 2023 08:34:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
Romsters
previously approved these changes
Oct 13, 2023
Romsters
approved these changes
Oct 16, 2023
|
🎉 This PR is included in version 2.14.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
pcheremu
pushed a commit
that referenced
this pull request
Feb 15, 2024
# What ❔ Docker compose file for CLI. Multi stage Docker file for App package. ## Why ❔ We need a slightly different docker compose configuration for CLI, so it was added. Docker file for App was changed to multi stage to make build consistent across all packages and introduce different stages for dev and prod envs. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Docker compose file for CLI. Multi stage Docker file for App package.
Why ❔
We need a slightly different docker compose configuration for CLI, so it was added.
Docker file for App was changed to multi stage to make build consistent across all packages and introduce different stages for dev and prod envs.
Checklist