fix: do not request verification info when running local node #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 1d619be):
(expires Mon, 23 Oct 2023 10:00:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
vasyl-ivanchuk
requested changes
Oct 13, 2023
There was a problem hiding this comment.
verificationApiUrlshould also be removed from/packages/app/src/configs/dev.config.jsonfor local network.- we have tests that check
verificationInfoin bothuseAddressanduseContractAPI, please add a case to check thatnullvalue is returned if there is noverificationApiUrlconfigured.
vasyl-ivanchuk
approved these changes
Oct 13, 2023
JackHamer09
force-pushed
the
do-not-request-verification-info-locally
branch
from
21aa7a2 to
1d619be
Compare
|
🎉 This PR is included in version 2.14.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
pcheremu
pushed a commit
that referenced
this pull request
Feb 15, 2024
# What ❔ - Do not request contract verification info when running against local node ## Why ❔ - Since contract verification is not yet implemented in the Block Explorer API the request simply fails and any contract page becomes unavailable --------- Co-authored-by: Vasyl Ivanchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔