Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sepolia testnet to config #55

Merged
merged 4 commits into from
Oct 18, 2023
Merged

feat: add sepolia testnet to config #55

merged 4 commits into from
Oct 18, 2023

Conversation

Romsters
Copy link
Collaborator

What ❔

Add sepolia testnet to the staging networks config

Why ❔

To be able to test the new network

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

API E2E Test Results

185 tests   185 ✔️  32s ⏱️
  12 suites      0 💤
    1 files        0

Results for commit 3ecdb70.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Unit Test Results

       3 files     237 suites   2m 40s ⏱️
1 831 tests 1 830 ✔️ 1 💤 0
1 856 runs  1 855 ✔️ 1 💤 0

Results for commit 3ecdb70.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Visit the preview URL for this PR (updated for commit 3ecdb70):

(expires Wed, 25 Oct 2023 07:04:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

Copy link
Collaborator

@vasyl-ivanchuk vasyl-ivanchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are number of failing e2e test which try to find a network by its name:

waiting for selector "//*[@class='network-list']//*[contains(text(), 'zkSync Era Testnet')] >> nth=0" to be visible

let's change the hardcoded network name there, too.

@Romsters Romsters merged commit e5e2cf3 into main Oct 18, 2023
24 checks passed
@Romsters Romsters deleted the add-sepolia-testnet branch October 18, 2023 08:45
@github-actions
Copy link

🎉 This PR is included in version 2.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

pcheremu pushed a commit that referenced this pull request Feb 15, 2024
# What ❔

Add sepolia testnet to the staging networks config

## Why ❔

To be able to test the new network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants