Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs for txlistinternal api endpoint #73

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

vasyl-ivanchuk
Copy link
Collaborator

What ❔

Improved docs for txlistinternal api endpoint

Why ❔

It's more user friendly to have separate swagger definitions for txlistinternal endpoint without params, with address and with txHash param.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@github-actions
Copy link

API E2E Test Results

202 tests   202 ✔️  39s ⏱️
  12 suites      0 💤
    1 files        0

Results for commit 4d0feab.

@github-actions
Copy link

Unit Test Results

       3 files     241 suites   2m 32s ⏱️
1 878 tests 1 877 ✔️ 1 💤 0
1 904 runs  1 903 ✔️ 1 💤 0

Results for commit 4d0feab.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 4d0feab):

(expires Tue, 07 Nov 2023 07:37:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

@vasyl-ivanchuk vasyl-ivanchuk merged commit 998a6fd into main Oct 31, 2023
24 checks passed
@vasyl-ivanchuk vasyl-ivanchuk deleted the improve-docs-for-txlistinternal branch October 31, 2023 07:46
@github-actions
Copy link

🎉 This PR is included in version 2.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

pcheremu pushed a commit that referenced this pull request Feb 15, 2024
# What ❔

Improved docs for txlistinternal api endpoint

## Why ❔

It's more user friendly to have separate swagger definitions for
txlistinternal endpoint without params, with address and with txHash
param.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [X] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [X] Tests for the changes have been added / updated.
- [X] Documentation comments have been added / updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants