fix: add missing fields to dtos #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a6ce882):
(expires Thu, 09 Nov 2023 13:16:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
Romsters
previously approved these changes
Nov 1, 2023
Romsters
reviewed
Nov 1, 2023
| description: "The type of the parent transaction", | ||
| example: "255", | ||
| }) | ||
| public readonly type: string; |
There was a problem hiding this comment.
Maybe it's better to use transactionType as well here? For consistency
Romsters
reviewed
Nov 1, 2023
| description: "The type of the transaction", | ||
| example: "255", | ||
| }) | ||
| public readonly type: string; |
There was a problem hiding this comment.
here just type is fine as it's transaction entity
Romsters
approved these changes
Nov 2, 2023
|
🎉 This PR is included in version 2.23.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
pcheremu
pushed a commit
that referenced
this pull request
Feb 15, 2024
# What ❔ Add missing fields to dtos so they are displayed in docs. ## Why ❔ A couple of fields were missing and are not displayed in docs. This PR is supposed to fix it. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Documentation comments have been added / updated. --------- Co-authored-by: Roman Petriv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Add missing fields to dtos so they are displayed in docs.
Why ❔
A couple of fields were missing and are not displayed in docs. This PR is supposed to fix it.
Checklist