Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transaction endpoint order #80

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

vasyl-ivanchuk
Copy link
Collaborator

What ❔

Transactions order fix.

Why ❔

Because current order doesn't take into account block numbers which is incorrect.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.

Copy link

github-actions bot commented Nov 7, 2023

API E2E Test Results

206 tests   206 ✔️  35s ⏱️
  14 suites      0 💤
    1 files        0

Results for commit 148a67c.

Copy link

github-actions bot commented Nov 7, 2023

Unit Test Results

       3 files     245 suites   8m 21s ⏱️
1 914 tests 1 913 ✔️ 1 💤 0
1 940 runs  1 939 ✔️ 1 💤 0

Results for commit 148a67c.

Copy link

github-actions bot commented Nov 7, 2023

Visit the preview URL for this PR (updated for commit 148a67c):

(expires Tue, 14 Nov 2023 18:51:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

@vasyl-ivanchuk vasyl-ivanchuk merged commit 08518d1 into main Nov 8, 2023
24 checks passed
@vasyl-ivanchuk vasyl-ivanchuk deleted the fix-transaction-endpoint-order branch November 8, 2023 09:03
Copy link

github-actions bot commented Nov 8, 2023

🎉 This PR is included in version 2.26.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

pcheremu pushed a commit that referenced this pull request Feb 15, 2024
# What ❔

Transactions order fix.

## Why ❔

Because current order doesn't take into account block numbers which is
incorrect.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [X] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [X] Tests for the changes have been added / updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants