Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transfers from Bootloader to an operator address #87

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

vasyl-ivanchuk
Copy link
Collaborator

What ❔

Fix for transfers from Bootloader to an operator address.

Why ❔

Not all transfers from Bootloader are Refunds. In blocks with no transactions transfers from Bootloader to an operator address are Transfers and have to be saved accordingly.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.

Copy link

github-actions bot commented Nov 13, 2023

API E2E Test Results

206 tests   206 ✔️  28s ⏱️
  14 suites      0 💤
    1 files        0

Results for commit e8f22cb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 13, 2023

Unit Test Results

       3 files     245 suites   8m 24s ⏱️
1 921 tests 1 920 ✔️ 1 💤 0
1 947 runs  1 946 ✔️ 1 💤 0

Results for commit e8f22cb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 13, 2023

Visit the preview URL for this PR (updated for commit e8f22cb):

(expires Tue, 21 Nov 2023 12:20:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

Romsters
Romsters previously approved these changes Nov 14, 2023
@vasyl-ivanchuk vasyl-ivanchuk merged commit c080938 into main Nov 14, 2023
24 checks passed
@vasyl-ivanchuk vasyl-ivanchuk deleted the fix-block-logs-transfers branch November 14, 2023 13:21
Copy link

🎉 This PR is included in version 2.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

pcheremu pushed a commit that referenced this pull request Feb 15, 2024
# What ❔

Fix for transfers from Bootloader to an operator address.

## Why ❔

Not all transfers from Bootloader are _Refunds_. In blocks with no
transactions transfers from Bootloader to an operator address are
_Transfers_ and have to be saved accordingly.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [X] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [X] Tests for the changes have been added / updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants