Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new tokens api #91

Merged
merged 6 commits into from
Nov 20, 2023
Merged

feat: use new tokens api #91

merged 6 commits into from
Nov 20, 2023

Conversation

Romsters
Copy link
Collaborator

What ❔

  • use new tokens API
  • remove token library
  • remove token price API usage
  • refactoring

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

API E2E Test Results

206 tests   206 ✔️  28s ⏱️
  14 suites      0 💤
    1 files        0 ❌

Results for commit cfd82dc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit cfd82dc):

(expires Mon, 27 Nov 2023 14:35:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

Unit Test Results

       3 files     244 suites   8m 37s ⏱️
1 920 tests 1 919 ✔️ 1 💤 0 ❌
1 946 runs  1 945 ✔️ 1 💤 0 ❌

Results for commit cfd82dc.

♻️ This comment has been updated with latest results.

vasyl-ivanchuk
vasyl-ivanchuk previously approved these changes Nov 17, 2023
View reviewed changes
@JackHamer09
Copy link
Member

I see that there are only 42 tokens in the list on mainnet. It seems because of the liquidity filter. Is this Era liquidity for these tokens? Cause the list looks really weird tbh.
Also what about the testnets? Do we have any token data for testnets?

@Romsters
Copy link
Collaborator Author

Romsters commented Nov 19, 2023 •
edited
Loading

I see that there are only 42 tokens in the list on mainnet. It seems because of the liquidity filter. Is this Era liquidity for these tokens? Cause the list looks really weird tbh. Also what about the testnets? Do we have any token data for testnets?

There are more tokens displayed now in fact, and yes, some of the tokens are not displayed because of the liquidity filter. This is not Era liquidity, this is global liquidity. We don't have tokens data for testnet, I think this is fine, etherscan also doesn't have testnet tokens data as there is no liquidity on testnet.

I think there is no need to display tokens with < 1m of liquidity, but this can be adjusted actually. We can display all the tokens with l1 address if we want, but then all the tokens anyone bridged (including spam) will be displayed.

@Romsters Romsters merged commit 52ee020 into main Nov 20, 2023
24 checks passed
@Romsters Romsters deleted the use-new-tokens-api branch November 20, 2023 14:52
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

pcheremu pushed a commit that referenced this pull request Feb 15, 2024
@Romsters @pcheremu
feat: use new tokens api (#91)
18392f0 
# What ❔

- use new tokens API
- remove token library
- remove token price API usage
- refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasyl-ivanchuk vasyl-ivanchuk vasyl-ivanchuk approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Romsters @JackHamer09 @vasyl-ivanchuk