fix: token icon label #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0009583):
(expires Tue, 28 Nov 2023 11:44:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
Romsters
approved these changes
Nov 21, 2023
|
🎉 This PR is included in version 2.29.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
pcheremu
pushed a commit
that referenced
this pull request
Feb 15, 2024
# What ❔ Refactor TokenIconLabel component and its usage. ## Why ❔ The problem came from the local environment where we don't have ETH in DB and it's not returned by the tokens endpoint so the custom token icon is shown: <img width="477" alt="image" src="https://github.com/matter-labs/block-explorer/assets/6553665/932bc268-6af3-4f3e-881f-43575068f680"> since we already have a token icon url in upsteam components - we can just pass it to TokenIconLabel component and simplify the component itself. <img width="474" alt="image" src="https://github.com/matter-labs/block-explorer/assets/6553665/1601b1c2-2f90-468a-a8c9-d725274436cf"> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Refactor TokenIconLabel component and its usage.
Why ❔
The problem came from the local environment where we don't have ETH in DB and it's not returned by the tokens endpoint so the custom token icon is shown:
since we already have a token icon url in upsteam components - we can just pass it to TokenIconLabel component and simplify the component itself.
Checklist