Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add validation to check bridge init log producer #98

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Romsters
Copy link
Collaborator

What ❔

  • validate bridge init log to be produced by bridge contract

Why ❔

  • if token is bridged outside of bridge it can't rely on provided token l1 address

Copy link

API E2E Test Results

206 tests   206 ✔️  28s ⏱️
  14 suites      0 💤
    1 files        0

Results for commit 79d5bf9.

Copy link

Visit the preview URL for this PR (updated for commit 79d5bf9):

(expires Thu, 30 Nov 2023 14:06:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

Copy link

Unit Test Results

       3 files     244 suites   8m 34s ⏱️
1 925 tests 1 924 ✔️ 1 💤 0
1 951 runs  1 950 ✔️ 1 💤 0

Results for commit 79d5bf9.

@Romsters Romsters merged commit c1acec5 into main Nov 23, 2023
23 of 24 checks passed
@Romsters Romsters deleted the fix-bridged-tokens-validation branch November 23, 2023 14:30
Copy link

🎉 This PR is included in version 2.29.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

pcheremu pushed a commit that referenced this pull request Feb 15, 2024
# What ❔

- validate bridge init log to be produced by bridge contract

## Why ❔

- if token is bridged outside of bridge it can't rely on provided token
l1 address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants