Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: covering Batches API and partially covered Transactions #99

Conversation

amelnytskyi
Copy link
Contributor

@amelnytskyi amelnytskyi commented Nov 24, 2023

What ❔

Covered the next TCs:

  • 1506 [Transactions] /transactions response returns elements (wasn't covered fully)
  • 1513 [Batches] /batches response returns elements (wasn't covered fully)
  • 1510 [Transactions] /address/{address}/logs response returns elements (wasn't covered fully)
  • 1656 [Transactions] Verify failed tx (wasn't covered)
  • 1655 [Transactions] Verify deployed the own ERC20 token contract in BE (wasn't covered)

Why ❔

Why are these changes done? - expanding test coverage

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

 covering Batches API
@amelnytskyi amelnytskyi added the automation writing/fixing/maintaining auto-tests/e2e-tests label Nov 24, 2023
@amelnytskyi amelnytskyi self-assigned this Nov 24, 2023
Copy link

github-actions bot commented Nov 24, 2023

API E2E Test Results

206 tests  ±0   206 ✔️ ±0   27s ⏱️ -1s
  14 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 047b68c. ± Comparison against base commit 7fe2e5a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 24, 2023

Visit the preview URL for this PR (updated for commit 047b68c):

(expires Mon, 04 Dec 2023 14:27:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

Copy link

github-actions bot commented Nov 24, 2023

Unit Test Results

       3 files  ±0     244 suites  ±0   8m 22s ⏱️ -5s
1 919 tests ±0  1 918 ✔️ ±0  1 💤 ±0  0 ±0 
1 945 runs  ±0  1 944 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit 047b68c. ± Comparison against base commit 7fe2e5a.

♻️ This comment has been updated with latest results.

@amelnytskyi
Copy link
Contributor Author

@pcheremu could you please review the PR?
Thanks in advance

@pcheremu
Copy link
Contributor

Sure, I will check it

Fixed check for status (since it could be different when running the test)
@amelnytskyi amelnytskyi deleted the QA-538-cover-batches-endpoint-and-failed-tx branch January 25, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation writing/fixing/maintaining auto-tests/e2e-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants