Improves workflows.

Replaces outdated ::set-output.
Removes unneeded secret.
Marks ssh public key as sensitive.
Fixes comments.

.github/workflows/docker_build.yaml

@@ -17,7 +17,8 @@ jobs:
 
       - name: Set outputs
         id: vars
-        run: echo "::set-output name=sha_short::$(git rev-parse --short HEAD)"
+        run: echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
+
       - name: Login to GAR
         run: |
           gcloud auth configure-docker us-docker.pkg.dev -q
@@ -29,11 +30,11 @@ jobs:
         id: set_version
         run: |
           if [[ ${{ github.ref }} =~ "refs/tags" ]]; then
-            echo "::set-output name=image_tag_suffix::${GITHUB_REF#refs/*/}"
+            echo "image_tag_suffix=${GITHUB_REF#refs/*/}" >> $GITHUB_OUTPUT
           else
             sha=$(git rev-parse --short HEAD)
             ts=$(date +%s%N | cut -b1-13)
-            echo "::set-output name=image_tag_suffix::${sha}-${ts}"
+            echo "image_tag_suffix=${sha}-${ts}" >> $GITHUB_OUTPUT
           fi
       - name: Log in to Docker Hub
         uses: docker/login-action@f4ef78c080cd8ba55a85445d5b36e214a81df20a # v2.1.0

.github/workflows/load_testing.yaml

@@ -51,7 +51,6 @@ jobs:
       - uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
         with:
           node-version: 16
-          token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Setup Terraform
         uses: hashicorp/setup-terraform@v2

docker/localenv.Dockerfile

@@ -24,7 +24,7 @@ RUN cargo run -p tools --bin localnet_config -- --nodes=$nodes
 WORKDIR /usr/src/myapp/node
 RUN cargo build -p executor --release
 
-# Create the artifacts directory 
+# Create the artifacts directory
 WORKDIR /usr/src/myapp/node/
 RUN i=0; \
     while [ $i -lt $nodes ]; do \
@@ -57,5 +57,5 @@ RUN i=0; \
         i=$(expr $i + 1); \
     done
 
-# Some rundom command
-CMD ["echo", "Done"]
+# Report succes
+CMD ["echo", "Done"]

infrastructure/loadtests/outputs.tf

@@ -1,9 +1,9 @@
-
 output "instance_public_ips" {
   description = "Public IPs of the instances"
   value       = [for instance in google_compute_instance.zksync_bft_node : instance.network_interface[0].access_config[0].nat_ip]
 }
 
 output "ssh_key" {
-  value = tls_private_key.ssh.public_key_openssh
+  value     = tls_private_key.ssh.public_key_openssh
+  sensitive = true
 }