Refactored TimeoutQC to contain just one CommitQC #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate space and helps with proving.
konnov
reviewed
Jul 5, 2024
Co-authored-by: Igor Konnov <[email protected]>
dnkolegov
pushed a commit
that referenced
this pull request
Aug 8, 2024
## What ❔ Following the pseudo-code updates in #144, this PR introduces updates in the Quint specification, namely, moving `CommitQC` into `TimeoutQC` and storing only `high_commit_qc_view` in `TimeoutVote` instead of storing `high_commit_qc`. ## Why ❔ This update speeds-up model checking times dramatically, as `CommitQC` fields in `TimeoutVote` were a major bottleneck. ~This change has broken multiple invariants. Hence, we have to further fix the specification and the invariants before merging.~ Preliminary experiments show that the model checking times have improved dramatically. For instance, we were able to find the expected violation of agreement for `N=6`, `F=1`, and `B=2`. --------- Co-authored-by: Bruno França <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Refactored (in the informal spec)
TimeoutQC,SignedTimeoutVoteandTimeoutVoteso thatTimeoutQCcontains only oneCommitQC(the high QC).Why ❔
It reduces the state space which should help with model checking.