fix: Add max_batch_size to limit the SyncBatch request sizes #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanBrodetski
approved these changes
Jul 9, 2024
brunoffranca
approved these changes
Jul 9, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adds a
max_batch_sizesetting and uses it to set amax_req_sizelimit in the RPC that deals withSyncBatch.Fixes some of the comments added in #150
Alternative configuration
The size of
SyncBatchdepends on how many blocks are in the batch, plus a fixed size proof. Since we already have a limit for the size of block payloads, ostensibly we could add a limit on the number of blocks in the batch; I used 100 in the protobuf reader if the field was missing. Perhaps this setting is already available somewhere in zksync-era?Why ❔
Tests failed in matter-labs/zksync-era#2340 when I unintentionally enabled the gossiping of
SyncBatchdue to the large size of the requests. It turns out they were either hardcoded constants copied from the block store state gossip (which doesn't depend on the payload size, only the QC), or they wrongly used the block payload limit.