feat: instrument code with tracing spans #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
reviewed
Aug 6, 2024
itegulov
commented
Aug 6, 2024
brunoffranca
approved these changes
Aug 6, 2024
pompon0
reviewed
Aug 7, 2024
pompon0
reviewed
Aug 7, 2024
pompon0
approved these changes
Aug 7, 2024
pompon0
reviewed
Aug 8, 2024
itegulov
force-pushed
the
daniyar/tracing-spans
branch
from
19c6590 to
87977a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR instruments all interesting* places within the system.
* "interesting" here is very subjective and I tried to use my understanding of the code to judge what should be covered and what shouldn't. Feel free to give feedback
Why ❔
Better observability