Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: In-memory storage implementation #18

Merged
merged 7 commits into from
Oct 31, 2023

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Oct 31, 2023

What ❔

Adds in-memory block and replica state storage implementation. Uses this implementation for tests instead of RocksDB implementation. The RocksDB implementation remains in the storage crate, but it's gated behind an off-by-default feature.

Why ❔

RocksDB involves more dependencies (incl. RocksDB compilation), which could be an overkill, especially for tests.

@slowli slowli marked this pull request as ready for review October 31, 2023 08:49
Copy link
Collaborator

@pompon0 pompon0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@pompon0 pompon0 merged commit 3705738 into main Oct 31, 2023
4 checks passed
@pompon0 pompon0 deleted the aov-bft-364-in-memory-storage-implementation branch October 31, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants