Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduced the lost span #182

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Reintroduced the lost span #182

merged 1 commit into from
Aug 14, 2024

Conversation

pompon0
Copy link
Contributor

@pompon0 pompon0 commented Aug 14, 2024

It was removed by accident during the instrumentation refactor.
The span name is intentionally short, so that the logs don't become too verbose

@pompon0 pompon0 requested a review from aakoshh August 14, 2024 07:17
Copy link
Contributor

@aakoshh aakoshh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were very useful indeed!

@pompon0 pompon0 merged commit 9a255d2 into main Aug 14, 2024
5 checks passed
@pompon0 pompon0 deleted the gprusak-revert-span branch August 14, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants