added build_version label to gossip handshake (BFT-502) #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
reviewed
Aug 20, 2024
aakoshh
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Looks good but I would implement some protection against spam, like a semver or length limit
I had to do a similar addition once to an Ethereum client, the format included the executable name, the platform and architecture and the version, eg. mantis/v3.0-cd5ae33/linux-amd64/ubuntu-openjdk64bitservervm-java-11.0.9
We don’t have multiple clients but I wouldn’t let anyone send unconstrained strings
|
The string is constrained by the Handshake message size. We will restrict it further if the need arises. |
brunoffranca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will allow us to monitor which nodes are using which version of the binary.
I've added a metric to count peers by their version (it is unbounded though).
I've added it to the http page display as well.
unrelated: I've removed Default impl for committees - it was creating invalid object.
unrelated: Exposed the validator::ProofOfPossession type.