Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for syncing pre-genesis blocks #203

Merged
merged 21 commits into from
Oct 9, 2024
Merged

Conversation

pompon0
Copy link
Collaborator

@pompon0 pompon0 commented Sep 30, 2024

We will sync blocks with merkle proofs for the whole batches, which obsoletes the unused "batch syncing" logic that we had.

I've introduced a concept of PreGenesisBlock which contains a custom Justification, and a verify_pre_genesis_block() method in PersistentBlockStore for verifying those.
Some of the RPC requests required tuning to provide backward compatibility.

I've removed WIRE from protobuf compatibility check, since it is a subset of WIRE_JSON.

Copy link
Member

@brunoffranca brunoffranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach looks good. There is the inconsistency of post-genesis blocks being verified on era-consensus while pre-genesis blocks are verified on zksync-era. But this is probably only solvable when we move the eth watcher to era-consensus.

@pompon0 pompon0 marked this pull request as ready for review October 8, 2024 15:15
@pompon0 pompon0 requested a review from brunoffranca October 8, 2024 15:15
brunoffranca
brunoffranca previously approved these changes Oct 8, 2024
node/libs/storage/src/block_store/mod.rs Show resolved Hide resolved
@pompon0 pompon0 merged commit 6a4a695 into main Oct 9, 2024
6 checks passed
@pompon0 pompon0 deleted the gprusak-ext-proof2 branch October 9, 2024 16:07
pompon0 pushed a commit that referenced this pull request Oct 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.5.0](v0.4.0...v0.5.0)
(2024-10-09)


### Features

* support for syncing pre-genesis blocks
([#203](#203))
([6a4a695](6a4a695))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants