Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expand metrics in HTTP debug page #205

Merged
merged 8 commits into from
Oct 7, 2024
Merged

feat: Expand metrics in HTTP debug page #205

merged 8 commits into from
Oct 7, 2024
+688 −241

Conversation

brunoffranca
Copy link
Member

@brunoffranca brunoffranca commented Oct 6, 2024 •
edited
Loading

What ❔

  • Almost all info in Network was added to the debug page. Exceptions are values related to batch gossiping (which is going to be deprecated) and message pools/queues (which I deemed too verbose to include, but can be included if necessary).
  • Fixed calculation of connection throughput. It now averages over the last minute.
  • Made all units human readable.
  • As a side effect, a couple of cargo files were formatted. The only real change was adding human_repr package. Will format the rest of the cargo files in a separate PR.

Fixes BFT-508

@brunoffranca brunoffranca requested a review from pompon0 as a code owner October 6, 2024 02:09
pompon0
pompon0 reviewed Oct 6, 2024
View reviewed changes
node/actors/network/src/gossip/validator_addrs.rs Show resolved Hide resolved
node/actors/network/src/metrics.rs Outdated Show resolved Hide resolved
node/actors/network/src/gossip/attestation/mod.rs Outdated Show resolved Hide resolved
node/actors/network/src/gossip/fetch.rs Outdated Show resolved Hide resolved
node/actors/network/src/metrics.rs Outdated Show resolved Hide resolved
node/actors/network/src/debug_page/mod.rs Outdated Show resolved Hide resolved
node/actors/network/src/debug_page/mod.rs Outdated Show resolved Hide resolved
@brunoffranca brunoffranca requested a review from pompon0 October 7, 2024 19:16
pompon0
pompon0 previously approved these changes Oct 7, 2024
View reviewed changes
@brunoffranca brunoffranca merged commit 2ef11bc into main Oct 7, 2024
6 checks passed
@brunoffranca brunoffranca deleted the bf-http branch October 7, 2024 22:52
@zksync-era-bot zksync-era-bot mentioned this pull request Oct 7, 2024
Merged
brunoffranca added a commit that referenced this pull request Oct 9, 2024
@zksync-era-bot @brunoffranca
chore(main): release 0.4.0 (#207)
50d24c6 
🤖 I have created a release *beep* *boop*
---


##
[0.4.0](v0.3.0...v0.4.0)
(2024-10-07)


### Features

* Expand metrics in HTTP debug page
([#205](#205))
([2ef11bc](2ef11bc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Co-authored-by: Bruno França <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompon0 pompon0 pompon0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunoffranca @pompon0