refactor: Removing actor pipes and naming #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented all types for ChonkyBFT. Work on this is all on the roles crate. Tests in roles crate are passing. Note that I'm not keeping the old types, that's because `ReplicaCommit` has no changes to it (I checked and serialization is the same for old and new, old signatures still work) as well as `CommitQC` and `FinalBlock`. Any type that an EN could receive, or that ends on our database, doesn't suffer any alterations. So it seems that the upgrade to ChonkyBFT is backwards-compatible for ENs. Since we only have one validator, we can upgrade the whole network without a planned hard fork. Part of BFT-452
- Everything in chonky_bft folder is basically new. - UTHarness was moved to chonky_bft/testonly.rs. Several changes to it though. - All tests that use UTHarness were moved to chonky_bft/tests. Some of the old unit tests were repurposed, but a fair amount of the tests in chonky_bft/tests are new. - The tests in tests.rs were split between tests/mod.rs and tests/twins.rs (except for a few that used UTHarness and were moved as said before). There were no changes to them though. Part of BFT-452
pompon0
reviewed
Nov 12, 2024
pompon0
reviewed
Nov 12, 2024
pompon0
reviewed
Nov 12, 2024
pompon0
reviewed
Nov 12, 2024
pompon0
reviewed
Nov 12, 2024
pompon0
reviewed
Nov 12, 2024
pompon0
reviewed
Nov 12, 2024
|
Added an exception to advisories on cargo deny. Needed because an upstream dependency became unmaintained, until kube updates their dependencies, it will remain. |
|
The advantage is the fact that you are aware of crates that use old dependencies and you can try to avoid them. It also actively prevents people from pinning dependency versions. |
|
We have never used a different dependency because of this. If it doesn't actually result in different behavior, then it's not useful information IMO. |
pompon0
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting rid of the whole actor pipe architecture. It was only created because we thought we would have many components, in reality we ended up with just two big components. This is just a refactor, no logic changes.