fix: TimeoutQC aggregation #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoffranca
previously approved these changes
Dec 11, 2024
brunoffranca
pushed a commit
that referenced
this pull request
Dec 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.0](v0.6.0...v0.7.0) (2024-12-16) ### Features * Added tool to recover public keys from secret keys ([#224](#224)) ([f1522f8](f1522f8)) * Added view timeout duration as a config parameter ([#222](#222)) ([f07fcfa](f07fcfa)) * loadtest improvements ([#223](#223)) ([69f11c7](69f11c7)) ### Bug Fixes * Fix high vote on informal spec ([#215](#215)) ([c586f85](c586f85)) * TimeoutQC aggregation ([#220](#220)) ([8a49824](8a49824)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Ord implementation was causing timeout votes with different high qc (with the same view) to be deduplicated, which invalidated the aggregated signature. I've added a test for this case, and preemptively removed all custom Ord implementations on messages.