Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Removed attester set from genesis #221

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: Removed attester set from genesis #221

wants to merge 2 commits into from

Conversation

brunoffranca
Copy link
Member

@brunoffranca brunoffranca commented Dec 11, 2024 •
edited
Loading

Fixes BFT-512

@brunoffranca brunoffranca requested a review from pompon0 December 11, 2024 17:08
pompon0
pompon0 reviewed Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@pompon0 pompon0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except that it shouldn't get merged before zksync-era stops using attester committee from genesis in tests and on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pompon0 pompon0 pompon0 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunoffranca @pompon0