Switch from sha256 to keccak256 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
reviewed
Nov 6, 2023
| @@ -43,7 +43,7 @@ impl Provider { | |||
| pub(super) fn test() -> Provider { | |||
| Self::Split( | |||
| SplitProvider { | |||
| builder: sha2::Sha256::new().chain("Lzr81nDW8eSOMH".as_bytes()), | |||
| builder: sha3::Keccak256::new().chain("Lzr81nDW8eSOMH".as_bytes()), | |||
There was a problem hiding this comment.
this has nothing to do with evm. Is keccak faster than sha?
There was a problem hiding this comment.
Depends. On hardware implementations Keccak/SHA3 is faster, but if there's no hardware support then it's slower than SHA2.
That being said, I just think it's easier for now to just use one hash algorithm for everything. If/when we do code profiling and realize that hashing is a bottleneck, we can change to a faster algorithm like BLAKE3 wherever we can.
pompon0
previously approved these changes
Nov 6, 2023
brunoffranca
previously approved these changes
Nov 6, 2023
slowli
previously approved these changes
Nov 7, 2023
|
|
||
| mod test; | ||
| pub mod testonly; |
There was a problem hiding this comment.
Off-topic (?): Why does this module need to be public? AFAICT, it doesn't contain public items.
There was a problem hiding this comment.
Not sure if you refer to line 5 (added) or 6 (already exists).
testonly: it needs to be public, although it works without the pub modifier, because visibility is bound to the trait implementation target type.test: I forgot to add the#[cfg(test)]attribute. Added now.
moshababo
dismissed stale reviews from slowli, brunoffranca, and pompon0
via
6e562ac
# Conflicts: # node/Cargo.lock # node/actors/network/src/noise/stream.rs # node/deny.toml # node/libs/crypto/src/keccak256/mod.rs # node/libs/crypto/src/lib.rs # node/libs/roles/src/node/messages.rs # node/libs/roles/src/validator/messages/block.rs # node/libs/roles/src/validator/messages/msg.rs
brunoffranca
approved these changes
Nov 9, 2023
pompon0
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from sha256 to keccak256 as the general-purpose hash function, to enhance compatibility with EVM/zkEVM.
Closing BFT-361.