Prefixed crate names with zksync_consensus_ #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
slowli
reviewed
Nov 6, 2023
| @@ -28,7 +28,7 @@ jobs: | |||
| path: "protobuf" | |||
| - uses: mozilla-actions/[email protected] | |||
| - name: build test | |||
| run: cargo build -p schema --bin conformance_test | |||
| run: cargo build -p zksync_consensus_schema --bin conformance_test | |||
There was a problem hiding this comment.
Off-topic (?): If we want to publish crates, I'd suggest to move this binary target to an example or a separate crate, so that it doesn't bring unnecessary extra deps (e.g., Tokio) as direct deps of the library. The same can be said about testonly modules in various crates (they may bring extra deps such as rand as well); so it would be better to gate this functionality behind an opt-in feature. Can be done later, of course.
There was a problem hiding this comment.
I would prefer to minimize the usage of the feature flags if possible. I don't know much about the crate publishing standards though.
brunoffranca
previously approved these changes
Nov 6, 2023
slowli
previously approved these changes
Nov 7, 2023
brunoffranca
approved these changes
Nov 7, 2023
slowli
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefixed crate names with zksync_consensus_ to make the names more scope specific.
We cannot afford keeping the generic names we used so far, as this repo will be used in zksync-era now.
The exception is zksync_concurrency (not zksync_consensus_concurrency) which is intended to be extracted from this repo eventually.