Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make Ctx::wait() public #26

Merged
merged 1 commit into from
Nov 7, 2023
Merged

feat: Make Ctx::wait() public #26

merged 1 commit into from
Nov 7, 2023

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Nov 7, 2023

What ❔

Makes Ctx::wait() public, so that it can be used by concurrency crate users.

Why ❔

This will provide a conventional way to wait for a cancel-safe future or context cancellation.

@slowli slowli marked this pull request as ready for review November 7, 2023 11:24
@slowli slowli requested a review from pompon0 as a code owner November 7, 2023 11:24
@slowli slowli requested a review from brunoffranca November 7, 2023 11:24
@slowli slowli merged commit 8a6838a into main Nov 7, 2023
4 checks passed
@slowli slowli deleted the aov-bft-369-expose-ctxwait branch November 7, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoffranca brunoffranca brunoffranca approved these changes

@pompon0 pompon0 pompon0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slowli @pompon0 @brunoffranca