Construct quorum certificate incrementally (BFT-386) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoffranca
changed the title
pompon0
reviewed
Dec 14, 2023
pompon0
reviewed
Dec 14, 2023
pompon0
reviewed
Dec 14, 2023
# Conflicts: # node/actors/bft/src/leader/replica_commit.rs # node/actors/bft/src/leader/replica_prepare.rs # node/actors/bft/src/leader/state_machine.rs # node/libs/roles/src/validator/messages/consensus.rs
Agree, I added the higher-level structs due to having additional fields. But I ended up removing all of them, delegating responsibility for correctness to the caller. |
moshababo
force-pushed
the
incremental_qc
branch
2 times, most recently
from
3107e95 to
7b14a56
Compare
moshababo
force-pushed
the
incremental_qc
branch
from
7b14a56 to
a274fc5
Compare
pompon0
reviewed
Dec 20, 2023
pompon0
reviewed
Dec 20, 2023
pompon0
reviewed
Dec 20, 2023
brunoffranca
approved these changes
Dec 20, 2023
pompon0
reviewed
Jan 1, 2024
pompon0
reviewed
Jan 1, 2024
pompon0
reviewed
Jan 1, 2024
pompon0
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructing quorum certificates from a batch of signed messages creates redundant error checks which are hard to reason about.
Since this operation's failure is unacceptable and can only occur as a result of a bug, it is preferred to construct incrementally upon receiving each message.
However, this refactoring ended up with no error checks during the incremental construction, delegating responsibility to the message processing.
Consequently, this change can be viewed merely as code cleanup which removes redundant error checks, and the incremental steps as a safer way to do that.
Notes
testonly. They can be removed altogether if tests will construct incrementally as well.PrepareQC::fromCommitQC::from(also seemed to had a duplicated error check which was removed)validator::AggregateSignature::aggregatebn254::AggregateSignature::aggregate