Improve get addrs #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bruno França <[email protected]>
moshababo
reviewed
Feb 29, 2024
pompon0
reviewed
Mar 7, 2024
pompon0
reviewed
Mar 7, 2024
pompon0
reviewed
Mar 7, 2024
pompon0
reviewed
Mar 7, 2024
pompon0
approved these changes
Mar 7, 2024
pompon0
reviewed
Mar 11, 2024
pompon0
reviewed
Mar 11, 2024
pompon0
reviewed
Mar 11, 2024
pompon0
reviewed
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Fixes https://linear.app/matterlabs/issue/BFT-429/improve-get-seed-node-addrs-function
Created a
ConsensusNodestruct to handle the internals of a k8s running node as well as its temporary configurationWhy ❔
The idea is to have a more object oriented code as stated in a comment in main k8s deployment script PR
Also, this
ConsensusNodestruct will be useful to handle the whole node configurations set for https://linear.app/matterlabs/issue/BFT-427/provide-full-config-as-a-cli-argument