Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dns support for the addresses in the config. #82

Merged
merged 16 commits into from
Mar 27, 2024
Merged

Conversation

pompon0
Copy link
Collaborator

@pompon0 pompon0 commented Mar 27, 2024

Added dns resolution support for the addresses in the config.
Now public_addr and gossip peers' addrs can be specified in <domain>:<port> format.
Validator address discovery still uses <IP>:<port> and validators announce their IP address only after verifying it (by establishing a loopback connection using the public_addr).

DNS ecosystem is slightly more centralized (requires authoritative DNS servers) than IP assignment, but not that much. It is useful in case of systems which have problem with providing stable IPs (like kubernetes). We need dns support at the very least for the non-public (stage) environment of zksync-era.

This pr also implements some minor related upgrades (like merged ArcMap functionality into Pool, and moved the sampling logic from zksync-era).

@pompon0 pompon0 requested a review from brunoffranca March 27, 2024 09:10
Copy link
Member

@brunoffranca brunoffranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A couple of nits.

node/libs/concurrency/src/net/mod.rs Outdated Show resolved Hide resolved
node/libs/protobuf/src/testonly/gen_value.rs Outdated Show resolved Hide resolved
node/libs/utils/src/encode.rs Show resolved Hide resolved
@pompon0 pompon0 merged commit ce92795 into main Mar 27, 2024
5 checks passed
@pompon0 pompon0 deleted the gprusak-dns branch March 27, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants