Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Upgrade zksolc version to 1.3.17 #72

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

thomas-nguy
Copy link
Member

@thomas-nguy thomas-nguy commented Nov 15, 2023

What ❔

Upgrading zksolc version to 1.3.17

Why ❔

Prior to 1.13.16, there is no binary available for linux-arm64 which is breaking the zk init or hyperchain init script
https://github.com/matter-labs/zksolc-bin/tree/main/linux-arm64

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@StanislavBreadless
Copy link
Collaborator

@thomas-nguy Hey, I understand the issue and generally using the latest compiler is preferred. However, updating the compiler is a change that would require an upgrade. Could you please redirect your PR to the dev branch? So that it would go into the next upgrader

@thomas-nguy thomas-nguy force-pushed the thomas/upgrade-zksolc-version branch from 69d971a to 62cf002 Compare November 15, 2023 10:42
@thomas-nguy thomas-nguy changed the title Upgrade zksolc version to 1.3.16 Upgrade zksolc version to 1.3.17 Nov 15, 2023
@thomas-nguy thomas-nguy changed the base branch from main to dev November 16, 2023 00:01
@StanislavBreadless
Copy link
Collaborator

@thomas-nguy could you please run yarn build && yarn calculate-hashes:fix to fix the CI? It mainly complains about the fact that the hashes of the system contracts will "unexpectedly" change

@thomas-nguy thomas-nguy force-pushed the thomas/upgrade-zksolc-version branch from a4aa449 to ef22c2d Compare November 22, 2023 01:14
@thomas-nguy
Copy link
Member Author

done :)

@thomas-nguy
Copy link
Member Author

thomas-nguy commented Nov 22, 2023

Mmm it seems the CI is still failing for some reasons? running locally yarn build && yarn calculate-hashes:fix give me always the same output (the one in this PR)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants