Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(proof-validation): handle optional proof status #225

Merged
merged 3 commits into from
Nov 28, 2024
Merged

fix(proof-validation): handle optional proof status #225

merged 3 commits into from
Nov 28, 2024

Conversation

haraldh
Copy link
Contributor

@haraldh haraldh commented Nov 28, 2024

Ensure proof status is treated as optional, preventing crashes when status is absent.

  • Modify status field to Option<String> in Proof struct.
  • Update validation logic to handle None values safely.
  • Adjust main logic to check for "permanently_ignored" safely.

@haraldh
fix(proof-validation): handle optional proof status
4a0a4f6 
Ensure proof status is treated as optional, preventing crashes when status is absent.
- Modify status field to `Option<String>` in `Proof` struct.
- Update validation logic to handle `None` values safely.
- Adjust main logic to check for "permanently_ignored" safely.
@haraldh haraldh requested a review from a team as a code owner November 28, 2024 14:50
@pbeza pbeza enabled auto-merge November 28, 2024 16:30
@pbeza pbeza merged commit e4629ae into main Nov 28, 2024
7 checks passed
@pbeza pbeza deleted the handle_old_proof_response branch November 28, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbeza pbeza pbeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haraldh @pbeza