Skip to content

Commit

Permalink
fix(zk chains): Increase Batch Seal Default Deadline (#3154)
Browse files Browse the repository at this point in the history
## What ❔

This PR increases the L1 Batch seadl default deadline from 1 hour to 8
hours.

## Why ❔

- For lower TPS chains, this configuration matches reality better and is
less wasteful in terms of Ethereum interactions.
- For higher TPS chains, the batches will be sealed by other seal
criteria anyways

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
  • Loading branch information
shahar4 authored Oct 23, 2024
1 parent 5092031 commit 11e525e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion etc/env/file_based/overrides/mainnet.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
state_keeper:
block_commit_deadline_ms: 3600000
# Default batch seal time deadline: 8 hours
block_commit_deadline_ms: 28000000
minimal_l2_gas_price: 45250000
eth:
sender:
Expand Down
3 changes: 2 additions & 1 deletion etc/env/file_based/overrides/testnet.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
state_keeper:
block_commit_deadline_ms: 3600000
# Default batch seal time deadline: 8 hours
block_commit_deadline_ms: 28000000
minimal_l2_gas_price: 25000000
eth:
sender:
Expand Down

0 comments on commit 11e525e

Please sign in to comment.