Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix spellcheck issues #1887

Merged
merged 1 commit into from
May 8, 2024
Merged

ci: Fix spellcheck issues #1887

merged 1 commit into from
May 8, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented May 8, 2024

What ❔

cargo-spellcheck got bumped to 0.14.0 in CI, and it started to discover more problems.
This PR aims to fix that.

Why ❔

Dead CI bad

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@popzxc popzxc requested review from EmilLuta and mm-zk May 8, 2024 13:42
@popzxc popzxc force-pushed the popzxc-spellcheck branch from a2874d2 to b8c4c68 Compare May 8, 2024 13:42
@EmilLuta EmilLuta enabled auto-merge May 8, 2024 13:43
@ilitteri
Copy link
Contributor

ilitteri commented May 8, 2024

There's an error with zk linkcheck that is removing the PR from the merge queue

 FILE: ./core/bin/snapshots_creator/README.md
  [✖] #snapshots-format
  [✓] ../../../docs/guides/setup-dev.md
  [✓] ../../tests/snapshot-recovery-test/tests/snapshot-recovery.test.ts
  [✓] ../../lib/types/src/snapshots.rs
  [✓] ../../lib/object_store

  5 links checked.

  ERROR: 1 dead links found!
  [✖] #snapshots-format → Status: 404

I got the same error locally, but the link works fine if I click it.

@EmilLuta
Copy link
Contributor

EmilLuta commented May 8, 2024

We're turning off linkcheck, usually breaks from github which rate limits us.

@EmilLuta EmilLuta added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@popzxc popzxc added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@popzxc popzxc added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@kelemeno
Copy link
Contributor

kelemeno commented May 8, 2024

Disabling linkcheck was not successful

@EmilLuta
Copy link
Contributor

EmilLuta commented May 8, 2024

Not really. We just can't get anything to merge. :/

@EmilLuta EmilLuta added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@EmilLuta EmilLuta added this pull request to the merge queue May 8, 2024
@popzxc popzxc removed this pull request from the merge queue due to a manual request May 8, 2024
@ml-ia ml-ia merged commit 59bb851 into main May 8, 2024
50 of 51 checks passed
@ml-ia ml-ia deleted the popzxc-spellcheck branch May 8, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants