Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(utils): Move bytecode hashing to basic_types #3258

Merged
merged 8 commits into from
Nov 14, 2024
Merged

refactor(utils): Move bytecode hashing to basic_types #3258

merged 8 commits into from
Nov 14, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Nov 12, 2024 •
edited
Loading

What ❔

Moves bytecode hashing logic to zksync_basic_types.

Why ❔

It belongs there by domain and further simplifies the dependency graph.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@slowli slowli marked this pull request as ready for review November 12, 2024 15:29
slowli
slowli commented Nov 12, 2024
View reviewed changes
core/lib/snapshots_applier/src/lib.rs Show resolved Hide resolved
core/lib/basic_types/Cargo.toml Outdated Show resolved Hide resolved
@slowli slowli requested a review from 0xVolosnikov November 13, 2024 07:46
popzxc
popzxc previously approved these changes Nov 13, 2024
View reviewed changes
core/lib/basic_types/Cargo.toml Outdated Show resolved Hide resolved
@slowli slowli requested a review from popzxc November 13, 2024 15:09
@slowli slowli added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
@slowli slowli added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 1edcabe Nov 14, 2024
43 checks passed
@slowli slowli deleted the aov-pla-1066-move-bytecode-hashing-to-basic_types branch November 14, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

@joonazan joonazan Awaiting requested review from joonazan

@RomanBrodetski RomanBrodetski Awaiting requested review from RomanBrodetski

@perekopskiy perekopskiy Awaiting requested review from perekopskiy

@0xVolosnikov 0xVolosnikov Awaiting requested review from 0xVolosnikov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowli @popzxc