Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contract-verifier): Download compilers from GH automatically #3291

Merged
merged 7 commits into from
Nov 21, 2024
Merged

feat(contract-verifier): Download compilers from GH automatically #3291

merged 7 commits into from
Nov 21, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Nov 15, 2024

Resolves #3257

  • Adds resolver multiplexer: implementation of resolver that would go through list of resolvers, trying to find one that works.
  • Adds GH resolver: implementation of resolver that is able to fetch releases from GH dynamically
  • Adds a task to periodically (1h) update the list of supported compiler versions.
  • GH resolver has a temporary kill switch: it can be disabled by setting DISABLE_GITHUB_RESOLVER env variable (in case we notice any problems).

⚠️ This PR doesn't contain any new tests, because I'm not sure if we want to rely on the availability of GH API. Mocking relevant parts (e.g. creating an alternative mock client for octocrab) would be very troublesome, so idk if it's justified. Happy to discuss.

I've checked the functionality manually though.

@popzxc popzxc requested review from slowli and perekopskiy November 15, 2024 10:43
slowli
slowli reviewed Nov 15, 2024
View reviewed changes
core/lib/contract_verifier/src/resolver/github/mod.rs Outdated Show resolved Hide resolved
core/lib/contract_verifier/src/resolver/github/mod.rs Outdated Show resolved Hide resolved
core/lib/contract_verifier/src/resolver/github/mod.rs Show resolved Hide resolved
core/lib/contract_verifier/src/resolver/github/mod.rs Show resolved Hide resolved
core/lib/contract_verifier/src/resolver/github/mod.rs Outdated Show resolved Hide resolved
core/lib/contract_verifier/src/resolver/mod.rs Outdated Show resolved Hide resolved
core/lib/contract_verifier/src/resolver/mod.rs Outdated Show resolved Hide resolved
core/lib/contract_verifier/src/resolver/github/gh_api.rs Show resolved Hide resolved
core/lib/contract_verifier/src/resolver/github/gh_api.rs Outdated Show resolved Hide resolved
core/lib/contract_verifier/src/resolver/github/gh_api.rs Show resolved Hide resolved
@popzxc popzxc requested a review from slowli November 18, 2024 13:30
perekopskiy
perekopskiy previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@perekopskiy perekopskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@popzxc popzxc added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@popzxc popzxc added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@popzxc popzxc added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit a10c4ba Nov 21, 2024
32 checks passed
@popzxc popzxc deleted the popzxc-auto-download-compilers branch November 21, 2024 11:15
This was referenced Nov 21, 2024
Open
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 11, 2024
@zksync-era-bot
chore(main): release core 25.3.0 (#3313)
503956d 
🤖 I have created a release *beep* *boop*
---


##
[25.3.0](core-v25.2.0...core-v25.3.0)
(2024-12-11)


### Features

* change seal criteria for gateway
([#3320](#3320))
([a0a74aa](a0a74aa))
* **contract-verifier:** Download compilers from GH automatically
([#3291](#3291))
([a10c4ba](a10c4ba))
* integrate gateway changes for some components
([#3274](#3274))
([cbc91e3](cbc91e3))
* **proof-data-handler:** exclude batches without object file in GCS
([#2980](#2980))
([3e309e0](3e309e0))
* **pruning:** Record L1 batch root hash in pruning logs
([#3266](#3266))
([7b6e590](7b6e590))
* **state-keeper:** mempool io opens batch if there is protocol upgrade
tx ([#3360](#3360))
([f6422cd](f6422cd))
* **tee:** add error handling for unstable_getTeeProofs API endpoint
([#3321](#3321))
([26f630c](26f630c))
* **zksync_cli:** Health checkpoint improvements
([#3193](#3193))
([440fe8d](440fe8d))


### Bug Fixes

* **api:** batch fee input scaling for `debug_traceCall`
([#3344](#3344))
([7ace594](7ace594))
* **tee:** correct previous fix for race condition in batch locking
([#3358](#3358))
([b12da8d](b12da8d))
* **tee:** fix race condition in batch locking
([#3342](#3342))
([a7dc0ed](a7dc0ed))
* **tracer:** adds vm error to flatCallTracer error field if exists
([#3374](#3374))
([5d77727](5d77727))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
@popzxc popzxc mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slowli slowli slowli approved these changes

@perekopskiy perekopskiy perekopskiy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically download new compiler versions in contract-verifier
3 participants
@popzxc @slowli @perekopskiy