fix(tracer): Add error to flat tracer #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil <[email protected]>
Signed-off-by: Danil <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
🤖 I have created a release *beep* *boop* --- ## [25.2.0](core-v25.1.0...core-v25.2.0) (2024-11-19) ### Features * add more metrics for the tee_prover ([#3276](#3276)) ([8b62434](8b62434)) * **api-server:** add `yParity` for non-legacy txs ([#3246](#3246)) ([6ea36d1](6ea36d1)) * **consensus:** fallback json rpc syncing for consensus ([#3211](#3211)) ([726203b](726203b)) * **contract-verifier:** Adapt contract verifier API for EVM bytecodes ([#3234](#3234)) ([4509179](4509179)) * **contract-verifier:** Support Solidity contracts with EVM bytecode in contract verifier ([#3225](#3225)) ([8a3a82c](8a3a82c)) * **contract-verifier:** Support Vyper toolchain for EVM bytecodes ([#3251](#3251)) ([75f7db9](75f7db9)) * **en:** Support Merkle tree recovery with pruning enabled ([#3172](#3172)) ([7b8640a](7b8640a)) * ProverJobProcessor & circuit prover ([#3287](#3287)) ([98823f9](98823f9)) * **prover:** Move prover_autoscaler config into crate ([#3222](#3222)) ([1b33b5e](1b33b5e)) * **vm_executor:** Add new histogram metric for gas per tx in vm_executor ([#3215](#3215)) ([3606fc1](3606fc1)) * **vm:** add gateway changes to fast vm ([#3236](#3236)) ([f3a2517](f3a2517)) ### Bug Fixes * **merkle-tree:** Repair stale keys for tree in background ([#3200](#3200)) ([363b4f0](363b4f0)) * **tracer:** Add error to flat tracer ([#3306](#3306)) ([7c93c47](7c93c47)) * use_dummy_inclusion_data condition ([#3244](#3244)) ([6e3c36e](6e3c36e)) * **vm:** Do not require experimental VM config ([#3270](#3270)) ([54e4b00](54e4b00)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Deniallugo
pushed a commit
that referenced
this pull request
Nov 21, 2024
🤖 I have created a release *beep* *boop* --- ## [25.2.0](core-v25.1.0...core-v25.2.0) (2024-11-19) ### Features * add more metrics for the tee_prover ([#3276](#3276)) ([8b62434](8b62434)) * **api-server:** add `yParity` for non-legacy txs ([#3246](#3246)) ([6ea36d1](6ea36d1)) * **consensus:** fallback json rpc syncing for consensus ([#3211](#3211)) ([726203b](726203b)) * **contract-verifier:** Adapt contract verifier API for EVM bytecodes ([#3234](#3234)) ([4509179](4509179)) * **contract-verifier:** Support Solidity contracts with EVM bytecode in contract verifier ([#3225](#3225)) ([8a3a82c](8a3a82c)) * **contract-verifier:** Support Vyper toolchain for EVM bytecodes ([#3251](#3251)) ([75f7db9](75f7db9)) * **en:** Support Merkle tree recovery with pruning enabled ([#3172](#3172)) ([7b8640a](7b8640a)) * ProverJobProcessor & circuit prover ([#3287](#3287)) ([98823f9](98823f9)) * **prover:** Move prover_autoscaler config into crate ([#3222](#3222)) ([1b33b5e](1b33b5e)) * **vm_executor:** Add new histogram metric for gas per tx in vm_executor ([#3215](#3215)) ([3606fc1](3606fc1)) * **vm:** add gateway changes to fast vm ([#3236](#3236)) ([f3a2517](f3a2517)) ### Bug Fixes * **merkle-tree:** Repair stale keys for tree in background ([#3200](#3200)) ([363b4f0](363b4f0)) * **tracer:** Add error to flat tracer ([#3306](#3306)) ([7c93c47](7c93c47)) * use_dummy_inclusion_data condition ([#3244](#3244)) ([6e3c36e](6e3c36e)) * **vm:** Do not require experimental VM config ([#3270](#3270)) ([54e4b00](54e4b00)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
…3374) ## What ❔ <!-- What are the changes this PR brings about? --> <!-- Example: This PR adds a PR template to the repo. --> <!-- (For bigger PRs adding more context is appreciated) --> - Updates `flatCallTracer` error to include vm error if it exists ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> - MM has requested that if an error exists we should populate within `flatCallTracer` as this is what others do, prior to this PR it was only revert_reason introduced here: #3306. However, if we have a vm error the error field is not populated as seen in this tx: `0x6c85bf34666dcdaa885f2bc6e95186029d2b25f2a3bbdff21c36878e2d4a19ed` which failed due to a vm panic. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.