-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zkstack_cli): Add the ability to run the server from Docker without building it #3314
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mostly nits
Update: currently checking the problem with exposing the ports to the host machine when running the server dockerized |
Recent updates to the config files on the main branch were not backward compatible. This causes the command thread 'main' panicked at core/node/eth_sender/src/aggregator.rs:76:72:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2024-12-03T09:36:56.978735Z DEBUG zksync_health_check: Changed health of `prometheus_exporter` from {"status":"not_ready"} to {"status":"panicked"}
2024-12-03T09:36:56.980158Z DEBUG zksync_health_check: Changed health of `tree` from {"status":"not_ready"} to {"status":"panicked"}
│
■ Command failed to run
│
■ Status:
│ exit status: 101
│ Stdout:
│
│
│ Stderr:
│
│
■ Failed to start server
│
▲ 0: Failed to run server
│ 1: Command failed to run: docker run --platform linux/amd64 -v ./chains/era/configs/genesis.yaml:/config/genesis.yaml -v ./chains/era/configs/wallets.yaml:/config/wallets.yaml -v ./chain |
What ❔
Currently we always run the server using cargo run. If you are not a developer. it’s unnecessary to build everything from scratch.
Why ❔
Checklist
zkstack dev fmt
andzkstack dev lint
.