refactor(zkstack): Preload chain and ecosystem config before each chain subcommand #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matias-gonz
changed the title
Deniallugo
reviewed
Nov 22, 2024
| @@ -95,15 +95,19 @@ pub(crate) async fn run(shell: &Shell, cmd: ChainCommands) -> anyhow::Result<()> | |||
|
|
|||
| match cmd { | |||
| ChainCommands::Create(args) => create::run(args, shell), | |||
| ChainCommands::Init(args) => init::run(*args, shell).await, | |||
| ChainCommands::BuildTransactions(args) => build_transactions::run(args, shell).await, | |||
| ChainCommands::Init(args) => init::run(*args, shell, chain, ecosystem).await, | |||
There was a problem hiding this comment.
Does it work with create function?
based on what i see it should fail for create or you have to unwrap chain
There was a problem hiding this comment.
It does because of this:
https://github.com/matter-labs/zksync-era/blob/matias/pre-load-ecosystem-and-chain/zkstack_cli/crates/zkstack/src/commands/chain/mod.rs#L89
I could remove create from the match clause to make it more clear that it will execute before
There was a problem hiding this comment.
Please add a comment there and also add unreachable
matias-gonz
changed the base branch from
matias/separate-chain-deploy-l2-contracts
to
matias/separate-chain-init
…ksync-era into matias/pre-load-ecosystem-and-chain
Deniallugo
approved these changes
Nov 26, 2024
…ksync-era into matias/pre-load-ecosystem-and-chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Preload chain and ecosystem config before each chain subcommand